Skip to content

bump libc version for uclibc fixes #96656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bump libc version for uclibc fixes #96656

wants to merge 1 commit into from

Conversation

skrap
Copy link
Contributor

@skrap skrap commented May 2, 2022

closes #95866

The required functions have been added to libc in rust-lang/libc#2750. That change made it into libc 0.2.124, but this just takes the latest libc.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 2, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2022
@skrap skrap mentioned this pull request May 2, 2022
Closed
@JohnTitor
Copy link
Member

Thanks!
r? @JohnTitor @bors r+

@bors
Copy link
Collaborator

bors commented May 3, 2022

📌 Commit c81734f has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 6, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96656 - skrap:master, r=JohnTitor
6983a7d 
bump libc version for uclibc fixes

closes rust-lang#95866

The required functions have been added to libc in rust-lang/libc#2750.  That change made it into libc 0.2.124, but this just takes the latest libc.
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 6, 2022
Closed
@klensy
Copy link
Contributor

klensy commented May 6, 2022

Already updated in #96510

@GuillaumeGomez
Copy link
Member

Indeed.

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 6, 2022
@JohnTitor
Copy link
Member

Good catch! Closing in favor of it.

@JohnTitor JohnTitor closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std lib build broken for uclibc
8 participants
@skrap @rust-highfive @JohnTitor @bors @klensy @GuillaumeGomez @Mark-Simulacrum @rustbot